From 027a27f7e115551e891b1faa63ba4b1ee8d7e991 Mon Sep 17 00:00:00 2001 From: innocentzero Date: Fri, 12 Apr 2024 17:30:39 +0530 Subject: [PATCH] style(fedora): Implicit types and module consts Use type inferencing for variables and move default repo filter to a constant. Signed-off-by: innocentzero --- .../pacdef_core/src/backend/actual/fedora.rs | 26 +++++++++---------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/crates/pacdef_core/src/backend/actual/fedora.rs b/crates/pacdef_core/src/backend/actual/fedora.rs index a14ec83..dd460c4 100644 --- a/crates/pacdef_core/src/backend/actual/fedora.rs +++ b/crates/pacdef_core/src/backend/actual/fedora.rs @@ -18,17 +18,21 @@ const BINARY: Text = "dnf"; const SECTION: Text = "fedora"; const SWITCHES_INFO: Switches = &[ - "repoquery", - "--installed", - "--queryformat", - "%{from_repo}/%{name}", -]; +const SWITCHES_INFO: Switches = &["info"]; const SWITCHES_INSTALL: Switches = &["install"]; const SWITCHES_MAKE_DEPENDENCY: Switches = &[]; const SWITCHES_NOCONFIRM: Switches = &["--assumeyes"]; const SWITCHES_REMOVE: Switches = &["remove"]; + "repoquery", + "--installed", + "--queryformat", + "%{from_repo}/%{name}", +]; + const SUPPORTS_AS_DEPENDENCY: bool = true; +/// fill stuff here +const DEFAULT_REPOS: [&str; 5] = ["koji", "fedora", "updates", "anaconda", "@"]; impl Backend for Fedora { impl_backend_constants!(); @@ -38,7 +42,7 @@ impl Backend for Fedora { cmd.args(self.get_switches_info()); let output = String::from_utf8(cmd.output()?.stdout)?; - let packages: HashSet = output.lines().map(create_package).collect(); + let packages = output.lines().map(create_package).collect(); Ok(packages) } @@ -53,7 +57,7 @@ impl Backend for Fedora { ]); let output = String::from_utf8(cmd.output()?.stdout)?; - let packages: HashSet = output.lines().map(create_package).collect(); + let packages = output.lines().map(create_package).collect(); Ok(packages) } @@ -112,13 +116,7 @@ impl Fedora { } fn create_package(package: &str) -> Package { - if (package.contains("koji") - || package.contains("fedora") - || package.contains("updates") - || package.contains("anaconda") - || package.contains('@')) - && !package.contains("copr") - { + if DEFAULT_REPOS.iter().any(|repo| package.contains(repo)) && !package.contains("copr") { let package = package.split('/').nth(1).expect("Cannot be empty!"); package.into() } else {