From 6e52b6d3d919e3e332bd529be408f32eff6ea7ed Mon Sep 17 00:00:00 2001 From: steven-omaha <35634100+steven-omaha@users.noreply.github.com> Date: Wed, 15 Feb 2023 17:39:55 +0100 Subject: [PATCH] add clippy::map_entry --- crates/pacdef_core/src/backend/backend_trait.rs | 8 +------- crates/pacdef_core/src/lib.rs | 1 + crates/pacdef_macros/src/lib.rs | 1 + 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/crates/pacdef_core/src/backend/backend_trait.rs b/crates/pacdef_core/src/backend/backend_trait.rs index 0b25300..94066bd 100644 --- a/crates/pacdef_core/src/backend/backend_trait.rs +++ b/crates/pacdef_core/src/backend/backend_trait.rs @@ -122,13 +122,7 @@ fn get_group_packages_map( let mut group_package_map = HashMap::new(); for (p, group) in to_assign { - if !group_package_map.contains_key(&group) { - group_package_map.insert(group.clone(), vec![]); - } - - let inner = group_package_map - .get_mut(&group) - .expect("either it was already there or we created it"); + let inner = group_package_map.entry(group).or_insert(vec![]); inner.push(p); } diff --git a/crates/pacdef_core/src/lib.rs b/crates/pacdef_core/src/lib.rs index 56f9631..acdf7c4 100644 --- a/crates/pacdef_core/src/lib.rs +++ b/crates/pacdef_core/src/lib.rs @@ -7,6 +7,7 @@ This library contains all logic that happens in `pacdef` under the hood. clippy::cognitive_complexity, clippy::explicit_iter_loop, clippy::explicit_into_iter_loop, + clippy::map_entry, clippy::missing_errors_doc, clippy::missing_panics_doc, clippy::option_if_let_else, diff --git a/crates/pacdef_macros/src/lib.rs b/crates/pacdef_macros/src/lib.rs index dafba6c..40161a5 100644 --- a/crates/pacdef_macros/src/lib.rs +++ b/crates/pacdef_macros/src/lib.rs @@ -7,6 +7,7 @@ Procedural macros for `pacdef`. clippy::cognitive_complexity, clippy::explicit_iter_loop, clippy::explicit_into_iter_loop, + clippy::map_entry, clippy::missing_errors_doc, clippy::missing_panics_doc, clippy::option_if_let_else,