From d39b2536a19a0a4e905745480ee2c8c9cdc85634 Mon Sep 17 00:00:00 2001
From: steven-omaha <35634100+steven-omaha@users.noreply.github.com>
Date: Fri, 3 Feb 2023 14:54:34 +0100
Subject: [PATCH] refactor divide_actions

---
 src/review/strategy.rs | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/review/strategy.rs b/src/review/strategy.rs
index d107b34..ca50ead 100644
--- a/src/review/strategy.rs
+++ b/src/review/strategy.rs
@@ -85,7 +85,16 @@ impl From<ReviewsPerBackend> for Vec<Strategy> {
         let mut result = vec![];
 
         for (backend, actions) in reviews {
-            let (to_delete, assign_group, as_dependency) = divide_actions(actions);
+            let mut to_delete = vec![];
+            let mut assign_group = vec![];
+            let mut as_dependency = vec![];
+
+            extract_actions(
+                actions,
+                &mut to_delete,
+                &mut assign_group,
+                &mut as_dependency,
+            );
 
             result.push(Strategy::new(
                 backend,
@@ -99,13 +108,12 @@ impl From<ReviewsPerBackend> for Vec<Strategy> {
     }
 }
 
-fn divide_actions(
+fn extract_actions(
     actions: Vec<ReviewAction>,
-) -> (Vec<Package>, Vec<(Package, Rc<Group>)>, Vec<Package>) {
-    let mut to_delete = vec![];
-    let mut assign_group = vec![];
-    let mut as_dependency = vec![];
-
+    to_delete: &mut Vec<Package>,
+    assign_group: &mut Vec<(Package, Rc<Group>)>,
+    as_dependency: &mut Vec<Package>,
+) {
     for action in actions {
         match action {
             ReviewAction::Delete(package) => to_delete.push(package),
@@ -113,6 +121,4 @@ fn divide_actions(
             ReviewAction::AsDependency(package) => as_dependency.push(package),
         }
     }
-
-    (to_delete, assign_group, as_dependency)
 }