fix clippy warnings

src/lib.rs

@@ -1,6 +1,6 @@
 pub mod lib {
-    use std::io::Write;
     use std::fs;
+    use std::io::Write;
 
     use zip;
 
@@ -51,18 +51,18 @@ pub mod lib {
     impl<T: Write> Handling for Descriptors<T> {
         fn write(&mut self, header: Vec<String>, bodies_by_coalition: BodiesByCoalition) {
             for line in &header {
-                write!(self.blue, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.blue, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
-                write!(self.red, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.red, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
-                write!(self.violet, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.violet, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
             }
             for line in &bodies_by_coalition.blue {
-                write!(self.blue, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.blue, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
             }
             for line in &bodies_by_coalition.red {
-                write!(self.red, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.red, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
             }
             for line in &bodies_by_coalition.violet {
-                write!(self.violet, "{}\n", line).expect(ERR_CANNOT_WRITE_DATA);
+                writeln!(self.violet, "{}", line).expect(ERR_CANNOT_WRITE_DATA);
             }
         }
     }
@@ -72,49 +72,57 @@ pub mod lib {
             let blue = fs::File::create(&filenames.txt.blue).expect(ERR_CANNOT_OPEN_OUTPUT);
             let red = fs::File::create(&filenames.txt.red).expect(ERR_CANNOT_OPEN_OUTPUT);
             let violet = fs::File::create(&filenames.txt.violet).expect(ERR_CANNOT_OPEN_OUTPUT);
-            let descriptors = Descriptors { blue, red, violet };
+            Descriptors { blue, red, violet }
-            return descriptors
         }
     }
 
     impl Descriptors<zip::ZipWriter<fs::File>> {
         pub fn new(filenames: OutputFilenames) -> Descriptors<zip::ZipWriter<fs::File>> {
-            let options = zip::write::FileOptions::default().compression_method(zip::CompressionMethod::Deflated);
+            let options = zip::write::FileOptions::default()
+                .compression_method(zip::CompressionMethod::Deflated);
 
             let file = fs::File::create(&filenames.zip.blue).expect(ERR_CANNOT_OPEN_OUTPUT);
             let mut blue = zip::ZipWriter::new(file);
-            blue.start_file(&filenames.txt.blue, options).expect(ERR_CANNOT_BEGIN_FILE);
+            blue.start_file(&filenames.txt.blue, options)
+                .expect(ERR_CANNOT_BEGIN_FILE);
 
             let file = fs::File::create(&filenames.zip.red).expect(ERR_CANNOT_OPEN_OUTPUT);
             let mut red = zip::ZipWriter::new(file);
-            red.start_file(&filenames.txt.red, options).expect(ERR_CANNOT_BEGIN_FILE);
+            red.start_file(&filenames.txt.red, options)
+                .expect(ERR_CANNOT_BEGIN_FILE);
 
             let file = fs::File::create(&filenames.zip.violet).expect(ERR_CANNOT_OPEN_OUTPUT);
             let mut violet = zip::ZipWriter::new(file);
-            violet.start_file(&filenames.txt.violet, options).expect(ERR_CANNOT_BEGIN_FILE);
+            violet
+                .start_file(&filenames.txt.violet, options)
+                .expect(ERR_CANNOT_BEGIN_FILE);
 
-            let descriptors = Descriptors{blue, red, violet};
+            Descriptors { blue, red, violet }
-            descriptors
         }
     }
 
-    pub fn sanity_check_output_filenames(input_filename: &String, output_filenames: &FilenamesVariant) {
+    pub fn sanity_check_output_filenames(
-        if input_filename == &output_filenames.blue ||
+        input_filename: &String,
-            input_filename == &output_filenames.red ||
+        output_filenames: &FilenamesVariant,
-            input_filename == &output_filenames.violet {
+    ) {
+        if input_filename == &output_filenames.blue
+            || input_filename == &output_filenames.red
+            || input_filename == &output_filenames.violet
+        {
             panic!("Output filenames were the same as input filenames")
         }
     }
 
-    pub fn get_output_filenames_individual(input_filename: &String, old_extension: &str, new_extension: &str, coalition: &str) -> String {
+    pub fn get_output_filenames_individual(
+        input_filename: &str,
+        old_extension: &str,
+        new_extension: &str,
+        coalition: &str,
+    ) -> String {
         let mut output_extension = coalition.to_owned();
         output_extension.push_str(new_extension);
-        let output_filename = input_filename.replace(old_extension, &output_extension);
+        input_filename.replace(old_extension, &output_extension)
-        output_filename
     }
-
-
-
 }
 
 #[cfg(test)]
@@ -125,12 +133,14 @@ mod tests {
         let input_filename = "something.txt.acmi".to_string();
         let extension = ".txt.acmi";
         let coalition = "_blue";
-        let result = get_output_filenames_individual(&input_filename, extension, extension, coalition);
+        let result =
+            get_output_filenames_individual(&input_filename, extension, extension, coalition);
         let correct_result = "something_blue.txt.acmi";
         assert_eq!(result, correct_result);
 
         let extension_wrong = ".tXT.acmi";
-        let result = get_output_filenames_individual(&input_filename, extension_wrong, extension, coalition);
+        let result =
+            get_output_filenames_individual(&input_filename, extension_wrong, extension, coalition);
         assert_ne!(result, correct_result);
     }
 }

src/main.rs

@@ -1,7 +1,5 @@
-use std::{fs, str};
 use std::io::{BufRead, BufReader};
-
+use std::{fs, str};
-use zip;
 
 use tacview_splitter::lib;
 use tacview_splitter::lib::Handling;
@@ -17,7 +15,7 @@ enum LineType {
     Unknown,
     Timestamp,
     Destruction,
-    Telemetry
+    Telemetry,
 }
 
 fn main() {
@@ -40,19 +38,28 @@ fn main() {
 fn split_into_header_and_body(lines: Vec<String>) -> (Vec<String>, Vec<String>) {
     let mut i = 0;
     for line in &lines {
-        if line.chars().nth(0).expect("malformed line") == COMMENT {
+        if line.chars().next().expect("malformed line") == COMMENT {
-            break
+            break;
         }
         i += 1;
     }
-    return (lines[..i].to_vec(), lines[i..].to_vec());
+    (lines[..i].to_vec(), lines[i..].to_vec())
 }
 
 fn divide_body_by_coalition(body: &Vec<String>) -> lib::BodiesByCoalition {
-    let mut bbc = lib::BodiesByCoalition{blue: Vec::new(), red: Vec::new(), violet: Vec::new()};
+    let mut bbc = lib::BodiesByCoalition {
+        blue: Vec::new(),
+        red: Vec::new(),
+        violet: Vec::new(),
+    };
     let mut continued = false;
     let mut line_type = LineType::Unknown;
-    let mut coalitions = lib::IDs{blue: Vec::new(), red: Vec::new(), violet: Vec::new(), unknown: Vec::new()};
+    let mut coalitions = lib::IDs {
+        blue: Vec::new(),
+        red: Vec::new(),
+        violet: Vec::new(),
+        unknown: Vec::new(),
+    };
     for line in body {
         let result = process_line(continued, &mut coalitions, line, line_type);
         line_type = result.0;
@@ -62,7 +69,8 @@ fn divide_body_by_coalition(body: &Vec<String>) -> lib::BodiesByCoalition {
             bbc.blue.push(line);
             bbc.red.push(line);
             bbc.violet.push(line);
-        } else {  // destruction or telemetry
+        } else {
+            // destruction or telemetry
             if coalitions.blue.contains(&id) {
                 bbc.blue.push(line);
             } else if coalitions.red.contains(&id) {
@@ -75,7 +83,12 @@ fn divide_body_by_coalition(body: &Vec<String>) -> lib::BodiesByCoalition {
     bbc
 }
 
-fn process_line<'a>(continued: bool, coalitions: &mut lib::IDs<'a>, line: &'a String, last_line_type: LineType) -> (LineType, bool, &'a str) {
+fn process_line<'a>(
+    continued: bool,
+    coalitions: &mut lib::IDs<'a>,
+    line: &'a str,
+    last_line_type: LineType,
+) -> (LineType, bool, &'a str) {
     let mut id = "";
     let line_type;
     if !continued {
@@ -91,27 +104,20 @@ fn process_line<'a>(continued: bool, coalitions: &mut lib::IDs<'a>, line: &'a St
     (line_type, line_will_continue, id)
 }
 
-fn will_line_continue(line: &String) -> bool {
+fn will_line_continue(line: &str) -> bool {
-    let line_will_continue: bool;
+    line.ends_with('\\')
-    if line.ends_with("\\") {
-        line_will_continue = true;
-    } else {
-        line_will_continue = false;
-    }
-    line_will_continue
 }
 
-fn get_id_from_line(line: &String) -> &str {
+fn get_id_from_line(line: &str) -> &str {
     let result = line.split_once(',');
     let split = match result {
         Some(t) => t,
-        None => panic!("Could not get ID from line!")
+        None => panic!("Could not get ID from line!"),
     };
-    let id = split.0;
+    split.0 as _
-    id
 }
 
-fn assign_id_to_coalitions<'a>(coalitions: &mut lib::IDs<'a>, line: &'a String, id: &'a str) {
+fn assign_id_to_coalitions<'a>(coalitions: &mut lib::IDs<'a>, line: &'a str, id: &'a str) {
     if line.contains("Color=") {
         if line.contains("Color=Blue") {
             coalitions.blue.push(id);
@@ -125,18 +131,15 @@ fn assign_id_to_coalitions<'a>(coalitions: &mut lib::IDs<'a>, line: &'a String,
     }
 }
 
-fn determine_line_type(line: &String) -> LineType {
+fn determine_line_type(line: &str) -> LineType {
-    let line_type: LineType;
+    let first_char = line.chars().next().expect("malformed line");
-
-    let first_char = line.chars().nth(0).expect("malformed line");
     if first_char == COMMENT {
-        line_type = LineType::Timestamp;
+        LineType::Timestamp
     } else if first_char == MINUS {
-        line_type = LineType::Destruction;
+        LineType::Destruction
     } else {
-        line_type = LineType::Telemetry;
+        LineType::Telemetry
     }
-    return line_type
 }
 
 fn get_output_filenames(input_filename: &String, is_zip: bool) -> lib::OutputFilenames {
@@ -144,35 +147,44 @@ fn get_output_filenames(input_filename: &String, is_zip: bool) -> lib::OutputFil
     let output_filenames_txt: lib::FilenamesVariant;
 
     if is_zip {
-        output_filenames_zip = get_output_filenames_for_extension(
+        output_filenames_zip =
-            input_filename, EXTENSION_ZIP, EXTENSION_ZIP
+            get_output_filenames_for_extension(input_filename, EXTENSION_ZIP, EXTENSION_ZIP);
-        );
+        output_filenames_txt =
-        output_filenames_txt = get_output_filenames_for_extension(
+            get_output_filenames_for_extension(input_filename, EXTENSION_ZIP, EXTENSION_TXT);
-            input_filename, EXTENSION_ZIP, EXTENSION_TXT
-        );
     } else {
         output_filenames_zip = get_output_filenames_dummy();
-        output_filenames_txt = get_output_filenames_for_extension(
+        output_filenames_txt =
-            input_filename, EXTENSION_TXT, EXTENSION_TXT
+            get_output_filenames_for_extension(input_filename, EXTENSION_TXT, EXTENSION_TXT);
-        );
     }
 
-    let output_filenames = lib::OutputFilenames{txt: output_filenames_txt, zip: output_filenames_zip};
+    lib::OutputFilenames {
-    output_filenames
+        txt: output_filenames_txt,
+        zip: output_filenames_zip,
+    }
 }
 
 fn get_output_filenames_dummy() -> lib::FilenamesVariant {
     let blue = "".to_string();
     let red = "".to_string();
     let violet = "".to_string();
-    let output_filenames = lib::FilenamesVariant{blue, red, violet};
+    lib::FilenamesVariant { blue, red, violet }
-    output_filenames
 }
 
-fn get_output_filenames_for_extension(input_filename: &String, old_extension: &str, new_extension: &str) -> lib::FilenamesVariant {
+fn get_output_filenames_for_extension(
-    let blue = lib::get_output_filenames_individual(input_filename, old_extension, new_extension, "_blue");
+    input_filename: &String,
-    let red = lib::get_output_filenames_individual(input_filename, old_extension,  new_extension,"_red");
+    old_extension: &str,
-    let violet = lib::get_output_filenames_individual(input_filename, old_extension,  new_extension,"_violet");
+    new_extension: &str,
+) -> lib::FilenamesVariant {
+    let blue =
+        lib::get_output_filenames_individual(input_filename, old_extension, new_extension, "_blue");
+    let red =
+        lib::get_output_filenames_individual(input_filename, old_extension, new_extension, "_red");
+    let violet = lib::get_output_filenames_individual(
+        input_filename,
+        old_extension,
+        new_extension,
+        "_violet",
+    );
     let output_filenames_zip = lib::FilenamesVariant { blue, red, violet };
     lib::sanity_check_output_filenames(input_filename, &output_filenames_zip);
     output_filenames_zip
@@ -189,27 +201,30 @@ fn find_input_file() -> (String, bool) {
         } else if filename.ends_with(EXTENSION_ZIP) {
             return (filename, true);
         }
-    };
+    }
     println!("No tacview input file found in current directory.");
     std::process::exit(1);
 }
 
-
 fn read_data(filename: &String, is_zip: bool) -> Vec<String> {
     let file = fs::File::open(filename).expect("Could not read from input file");
     let buf = BufReader::new(file);
     return if is_zip {
         let mut archive = zip::ZipArchive::new(buf).expect("Could not read zip data");
-        let inner_file = archive.by_index(0).expect("Could not read telemetry file from zip archive");
+        let inner_file = archive
+            .by_index(0)
+            .expect("Could not read telemetry file from zip archive");
         let inner_buf = BufReader::new(inner_file);
-        let lines: Vec<String> = inner_buf.lines()
+        let lines: Vec<String> = inner_buf
+            .lines()
             .map(|l| l.expect("Could not parse line"))
             .collect();
         lines
     } else {
-        let lines: Vec<String> = buf.lines()
+        let lines: Vec<String> = buf
+            .lines()
             .map(|l| l.expect("Could not parse line"))
             .collect();
         lines
-    }
+    };
 }