From 133c14cace271a3f9820b724952e4a6b15d80240 Mon Sep 17 00:00:00 2001 From: timeshifter Date: Wed, 1 Dec 2021 21:01:37 +0100 Subject: [PATCH] fix: argument order of _get_last_common_snapshot --- zfs-backup.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zfs-backup.py b/zfs-backup.py index ee7ed21..7636f16 100755 --- a/zfs-backup.py +++ b/zfs-backup.py @@ -74,7 +74,7 @@ class Manager: local_dataset, self._external_pool ) start_snapshot = self._get_last_common_snapshot( - remote_dataset, local_dataset + local_dataset, remote_dataset ) end_snapshot = self._get_last_snapshot_with_backup_tag(local_dataset) sender = ZFS.send_incremental(start_snapshot, end_snapshot) @@ -114,11 +114,11 @@ class Manager: return dataset @classmethod - def _get_last_common_snapshot(cls, ds1: Dataset, ds2: Dataset) -> Snapshot: + def _get_last_common_snapshot(cls, local_dataset: Dataset, remote_dataset: Dataset) -> Snapshot: common_snapshots = [ local_snap - for local_snap in list(cls._find_snapshots_with_backup_tag(ds1)) - for remote_snap in list(cls._find_snapshots_with_backup_tag(ds2)) + for local_snap in list(cls._find_snapshots_with_backup_tag(local_dataset)) + for remote_snap in list(cls._find_snapshots_with_backup_tag(remote_dataset)) if local_snap.snapname == remote_snap.snapname ] common_snapshots.sort()