timeshifter/zfs-backup
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: argument order of _get_last_common_snapshot

Browse Source
This commit is contained in:
timeshifter
2021-12-01 21:01:37 +01:00
parent d61b958304
commit 133c14cace
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zfs-backup.py
+4 -4
View File
@@ -74,7 +74,7 @@ class Manager:
local_dataset, self._external_pool local_dataset, self._external_pool
) )
start_snapshot = self._get_last_common_snapshot( start_snapshot = self._get_last_common_snapshot(
remote_dataset, local_dataset local_dataset, remote_dataset
) )
end_snapshot = self._get_last_snapshot_with_backup_tag(local_dataset) end_snapshot = self._get_last_snapshot_with_backup_tag(local_dataset)
sender = ZFS.send_incremental(start_snapshot, end_snapshot) sender = ZFS.send_incremental(start_snapshot, end_snapshot)
@@ -114,11 +114,11 @@ class Manager:
return dataset return dataset
@classmethod @classmethod
def _get_last_common_snapshot(cls, ds1: Dataset, ds2: Dataset) -> Snapshot: def _get_last_common_snapshot(cls, local_dataset: Dataset, remote_dataset: Dataset) -> Snapshot:
common_snapshots = [ common_snapshots = [
local_snap local_snap
for local_snap in list(cls._find_snapshots_with_backup_tag(ds1)) for local_snap in list(cls._find_snapshots_with_backup_tag(local_dataset))
for remote_snap in list(cls._find_snapshots_with_backup_tag(ds2)) for remote_snap in list(cls._find_snapshots_with_backup_tag(remote_dataset))
if local_snap.snapname == remote_snap.snapname if local_snap.snapname == remote_snap.snapname
] ]
common_snapshots.sort() common_snapshots.sort()